Fix bwc @timestamp upgrade issue by adding a version check on skip_list param #19670
+24
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asimmahmood1
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
asimmahmood1
force-pushed
the
fix_skiplist_default_bwc
branch
from
4463b53 to
6845052
Compare
…aram (bwc) Fixes opensearch-project#19660 Signed-off-by: Asim Mahmood <[email protected]>
asimmahmood1
force-pushed
the
fix_skiplist_default_bwc
branch
from
6845052 to
87f8eca
Compare
|
❌ Gradle check result for 87f8eca: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This skip_list param was introduced in 3.3.0, so any index created since then will have skip_list set to true. This way older indexes with @timestamp or index sort date field will continue to remain zero.
This way new indexes can take advantage of the performance enhancement in date histogram aggregation.
This is proper fix compared to #19661
Testing
Manually tested appending to big5 index created using 3.2.0.
Looking at how to add a bwc integ test. Existing ones do not have date field.
Related Issues
Fixes #19660
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.